----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107939/#review24048 -----------------------------------------------------------
services/fileindexer/indexer/okularextractor.cpp <http://git.reviewboard.kde.org/r/107939/#comment18337> As per our discussion I think it would be better if you manually crafted the list of mimetypes you want this plugin to support. Okular could add support for some esoteric format, and I would like that format tested in Nepomuk before adding support for it. Specially cause that format may not be a document. (Example - gif). Also, we may already support that format in which case we will have 2 clashing extractors. PS: Please make sure okular supports the formats in the manually constructed list. - Vishesh Handa On Dec. 27, 2012, 1:08 p.m., Rohan Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107939/ > ----------------------------------------------------------- > > (Updated Dec. 27, 2012, 1:08 p.m.) > > > Review request for Nepomuk. > > > Description > ------- > > Use the Okular API to extract information out of files that are supported by > Okular (mobi/epub/etc) with the added exception of not indexing pdf files. > > > Diffs > ----- > > CMakeLists.txt 6766e4b112258465aee93cd1d13cf619b1f3aa5e > services/fileindexer/indexer/CMakeLists.txt > f7b5d2a29dc4098cda3997f338adf45b211c4872 > services/fileindexer/indexer/main.cpp > 4d6fcfdb1b5231bd8af1c606f4b13a0cae89639d > services/fileindexer/indexer/nepomukokularextractor.desktop PRE-CREATION > services/fileindexer/indexer/okularextractor.h PRE-CREATION > services/fileindexer/indexer/okularextractor.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/107939/diff/ > > > Testing > ------- > > Indexed an epub file using : nepomukindexer --data file.epub, could see all > the data that was indexed on the terminal > > Sample epub : > https://epub-samples.googlecode.com/files/epub30-spec-20121128.epub > > NOTE: Install kdegraphics-mobi to get mobi support. > > > Thanks, > > Rohan Garg > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
