----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108114/#review24564 -----------------------------------------------------------
Ship it! Seems good enough to me! CMakeLists.txt <http://git.reviewboard.kde.org/r/108114/#comment18847> Please bump this to 4.8 at least. NepomukCore was introduced with KDE 4.8. CMakeLists.txt <http://git.reviewboard.kde.org/r/108114/#comment18848> Please remove this line. I couldn't figure out how to remove lines with my script. resourceview.cpp <http://git.reviewboard.kde.org/r/108114/#comment18849> Not really required :) resourceview.cpp <http://git.reviewboard.kde.org/r/108114/#comment18850> SimpleResources are something completely different and generally only used when feeding large quantities of data into Nepomuk. sparqlCompleter.diff <http://git.reviewboard.kde.org/r/108114/#comment18851> I just checked and it seems that I committed this file. Such an idiotic move. Please feel free to delete it. - Vishesh Handa On Jan. 3, 2013, 1:47 p.m., David Narváez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108114/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2013, 1:47 p.m.) > > > Review request for Nepomuk. > > > Description > ------- > > I ran the migration shell script, made a couple of changes to adjust Thing to > Resource and migrated a couple of classes into the utils folder as suggested > at http://lists.kde.org/?l=nepomuk&m=135720407314453&w=2 > > > Diffs > ----- > > CMakeLists.txt 1b4dc15 > classmodel.h 10b8d03 > classmodel.cpp 35fe196 > mainwindow.h f19ea07 > mainwindow.cpp 2f3e3bb > newclassdialog.h dd359c6 > newclassdialog.cpp 4916aee > pimomodel.h 91eee95 > pimomodel.cpp 46267df > queryeditor.h e8d815d > queryeditor.cpp 9e9f39c > querymodel.h 698dfee > querymodel.cpp 893d692 > resourcebrowserwidget.h 2b34c4f > resourcebrowserwidget.cpp f3271b9 > resourceeditorwidget.h 4f5c36b > resourceeditorwidget.cpp 41e1bdf > resourcepropertymodel.h ede4b53 > resourcepropertymodel.cpp 1d5d62b > resourcequerywidget.h e914e28 > resourcequerywidget.cpp 5172391 > resourceview.h 021069d > resourceview.cpp 1987fa3 > sparqlCompleter.diff 336b46e > sparqlsyntaxhighlighter.h a9c93d3 > sparqlsyntaxhighlighter.cpp f4d7774 > utils/README PRE-CREATION > utils/nepomukutils_export.h PRE-CREATION > utils/resourcemodel.h PRE-CREATION > utils/resourcemodel.cpp PRE-CREATION > utils/simpleresourcemodel.h PRE-CREATION > utils/simpleresourcemodel.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/108114/diff/ > > > Testing > ------- > > Ran nepomukshell, then I saw the Thing class and could expand around and see > derived classes, etc. I have very few resources in my display but I guess > that is an internal problem and nothing to do with the shell. > > > Thanks, > > David Narváez > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
