----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108271/#review25037 -----------------------------------------------------------
This review has been submitted with commit add83a0c51a48c5911222e21f67c036bdb13c1df by Vishesh Handa to branch KDE/4.10. - Commit Hook On Jan. 8, 2013, 5:36 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108271/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2013, 5:36 p.m.) > > > Review request for Nepomuk, David Faure and Simeon Bird. > > > Description > ------- > > The SearchRunnable classes used to contain a reference to the Folder and > call certain functions on it. Since the SearchRunnables were in another > thread this required mutexes and still often resulted in deadlocks and > crashes. > > The new code uses signals and slots to communicate between the Folder > and the SearchRunnable classes. This is a lot more elegant and easier to > understand. > > As far as I see the m_runnableMutex is no longer required. Could someone > confirm? Or should I just let it be? > > > Diffs > ----- > > services/storage/query/countqueryrunnable.h 3086656 > services/storage/query/countqueryrunnable.cpp 14c7917 > services/storage/query/folder.h 4baf092 > services/storage/query/folder.cpp 0fed8d2 > services/storage/query/searchrunnable.h ca4f596 > services/storage/query/searchrunnable.cpp 81a23ac > > Diff: http://git.reviewboard.kde.org/r/108271/diff/ > > > Testing > ------- > > Basic functionality testing done. It's a little hard to test the > multi-threading part of it. > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
