----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108335/#review25266 -----------------------------------------------------------
Ship it! If those widget can never change their parent, then it's okey to set the color role in the constructor. Otherwise, I would have preferred the "grab color role on Polish event" as KCommentWidget does. - Christoph Feck On Jan. 11, 2013, 7:24 p.m., Emmanuel Pescosta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108335/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2013, 7:24 p.m.) > > > Review request for Dolphin, Nepomuk and Frank Reininghaus. > > > Description > ------- > > Use right foreground role in Nepomuk2::TagCheckBox::m_label > > > This addresses bug 303875. > http://bugs.kde.org/show_bug.cgi?id=303875 > > > Diffs > ----- > > ui/tagcheckbox.cpp 7e402c2 > ui/tagwidget.cpp 5d1ef1c > > Diff: http://git.reviewboard.kde.org/r/108335/diff/ > > > Testing > ------- > > Done. Screenshot attached > > > Screenshots > ----------- > > Old and new look (screenshot includes also the html tags patch) > http://git.reviewboard.kde.org/r/108335/s/1020/ > > > Thanks, > > Emmanuel Pescosta > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
