----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109991/#review31740 -----------------------------------------------------------
common/regexpcache.h <http://git.reviewboard.kde.org/r/109991/#comment23654> const QString& outerPatten common/regexpcache.h <http://git.reviewboard.kde.org/r/109991/#comment23655> const QString& common/regexpcache.h <http://git.reviewboard.kde.org/r/109991/#comment23657> Could you please add some documentation for this function as well? common/regexpcache.h <http://git.reviewboard.kde.org/r/109991/#comment23658> I'm just thinking aloud over here, but maybe we just use user and int instead of size_t. It's easier to read and wouldn't really make any difference. Opinions? common/regexpcache.cpp <http://git.reviewboard.kde.org/r/109991/#comment23656> why do this? why not just QRegExp() if you want to clear it. - Vishesh Handa On April 24, 2013, 6:45 a.m., Lukasz Olender wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109991/ > ----------------------------------------------------------- > > (Updated April 24, 2013, 6:45 a.m.) > > > Review request for Nepomuk and Vishesh Handa. > > > Description > ------- > > It's related with https://bugs.kde.org/show_bug.cgi?id=303654. > P.S. I accidentally deleted author's and license info in patch. Isolated > performance tests are also uploaded to http://www.sendspace.com/file/mkihdp > (previous link not always work). It's my first patch. > > > This addresses bug 303654. > http://bugs.kde.org/show_bug.cgi?id=303654 > > > Diffs > ----- > > common/regexpcache.h d89f968 > common/regexpcache.cpp df45277 > > Diff: http://git.reviewboard.kde.org/r/109991/diff/ > > > Testing > ------- > > > Thanks, > > Lukasz Olender > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
