> On May 4, 2013, 6:42 p.m., Vishesh Handa wrote: > > services/filewatch/nepomukfilewatch.cpp, line 175 > > <http://git.reviewboard.kde.org/r/110301/diff/1/?file=142065#file142065line175> > > > > This won't work - > > > > Suppose my indexed folder is ~/Music. First it will start watching my > > home cause of line 170ΒΈ and then it will add ~/Music cause of line 175. It > > will then proceed to add watches for each folder in HOME and then each > > directory in ~/Music even though that already has watches. > > > > > > So we are essentially watching the same thing twice. > > > > You should call KInotify::watchingPath(..) before
No, this is ok - watchingPath is called inside watchFolder - see line 208. > On May 4, 2013, 6:42 p.m., Vishesh Handa wrote: > > services/fileindexer/fileindexer.cpp, line 107 > > <http://git.reviewboard.kde.org/r/110301/diff/1/?file=142064#file142064line107> > > > > Remove the implementation of this function from the filewatcher? Who > > needs to access it now? > > > > You'll also need to update the dbus interface xml file Sure, done. - Simeon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110301/#review32023 ----------------------------------------------------------- On May 4, 2013, 5:52 p.m., Simeon Bird wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110301/ > ----------------------------------------------------------- > > (Updated May 4, 2013, 5:52 p.m.) > > > Review request for Nepomuk and Vishesh Handa. > > > Description > ------- > > Filewatch: move all filewatching into the filewatch service > > Remove watch adding in the fileindexer service. > On a config change they were previously being re-added twice. > > Then watch all indexed folders in filewatch constructor. > This is needed so that nepomukctl restart filewatch watches all indexed > folders. > Don't bother to wait two minutes before installing the watches - it > isn't that slow anymore and we were doing most of the work anyway by > watching the homedir on startup. > > > Diffs > ----- > > services/fileindexer/fileindexer.h 1171b1190768f89491c66b6c4540f6631ef3b4cc > services/fileindexer/fileindexer.cpp > bd7ab6b83ced4cd02a4ffd20e85f64e52ac9acfd > services/filewatch/nepomukfilewatch.cpp > c3e72931a218e9afc757cc3bcf51e14fc9e3689d > > Diff: http://git.reviewboard.kde.org/r/110301/diff/ > > > Testing > ------- > > Compiled, ran, checked it responds to config changes correctly. > > > Thanks, > > Simeon Bird > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
