On 05/14/2013 03:34 PM, Vishesh Handa wrote:
Hey Sebastian

I just made a patch to remove the
DataManagementModel::containsResourceWithProtectedType function. This function
is a little slow and in my benchmarks it takes about 8% of the total execution
time.

The only reason this is there is to make sure clients do not add or modify
classes, properties or graphs through the DataManagement APIs. But I don't
think it is worth the 8% penalty.

Nowadays we have a pretty good view of who all is using Nepomuk and we can
control what they are doing.

Any comments?

I don't like it but performance is important. And eventually you are the maintainer (and I know I am repeating myself but you are doing a fine job at it). :)

So go ahead, or maybe make it configurable? As to not loose the code?
_______________________________________________
Nepomuk mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/nepomuk

Reply via email to