----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106467/#review33136 -----------------------------------------------------------
backends/virtuoso/odbcqueryresult.cpp <http://git.reviewboard.kde.org/r/106467/#comment24505> The problem was that this should have had a +1 in the end to account for the null character. Tested extensively. It now works. I'll be committing. This gives a 20-23% performance upgrade. Tested by fetching 50000 quads. - Vishesh Handa On Sept. 17, 2012, 9:37 a.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106467/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2012, 9:37 a.m.) > > > Review request for Nepomuk, Soprano and Sebastian Trueg. > > > Description > ------- > > Only use 1 SQLFetchData command in most of the cases. > > Callgrind stats show that 67.5% of the time in this function is spent in > the first SQLFetchData, and an additional 27% in the second SQLGetData. > We can avoid some of this extra cost, by only calling the function > once. > > I can change the size of the default buffer if required. > > > Diffs > ----- > > backends/virtuoso/odbcqueryresult.cpp a4f2387 > > Diff: http://git.reviewboard.kde.org/r/106467/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
