> On June 3, 2013, 11:13 a.m., Vishesh Handa wrote: > > Nice! > > > > Could you also add these ape files to > > Nepomuk2::SimpleIndexingJob::typesForMimeType(QString)? > > (nepomuk-core/services/fileindexer/indexer/simpleindexingjob.cpp). That way > > ape files will be counted as Audio files and shown after the first phase > > indexing as well. > > > > Also, could you please commit this to master and not 4.10. The KDE/4.10 > > branch is in a messed up state. I rather not touch it. > > Vishesh Handa wrote: > Also, try nepomukshow --depth 2 Facedancers.ape
Is that needed? Isn't it already covered with audio mimeType? - Hrvoje ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110767/#review33641 ----------------------------------------------------------- On June 3, 2013, 1:02 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110767/ > ----------------------------------------------------------- > > (Updated June 3, 2013, 1:02 p.m.) > > > Review request for Nepomuk and Vishesh Handa. > > > Description > ------- > > Some people have them, so why not index them ;-) > > > Diffs > ----- > > services/fileindexer/indexer/taglibextractor.cpp 941cf74 > > Diff: http://git.reviewboard.kde.org/r/110767/diff/ > > > Testing > ------- > > nepomukshow --depth 2 The\ Facedancers\ -\ The\ Facedancers.ape > <nepomuk:/res/df466c3e-adbc-46b8-bad4-bcb45ac91b13> > rdf:type nmm:MusicPiece > > rdf:type nfo:Audio > > rdf:type nfo:FileDataObject > > rdf:type nie:InformationElement > > nao:created 2013-06-02T09:31:31.537Z > > nao:lastModified 2013-06-02T09:34:25.415Z > > nie:url file:///home/hrvoje/Music/60's/The Facedancers - > 1972 - The Facedancers/The Facedancers - The Facedancers.ape > nie:mimeType audio/x-ape > > nie:title The Facedancers > > nie:lastModified 2013-06-01T16:37:37Z > > nie:created 2013-06-01T16:37:37Z > > nfo:averageBitrate 6.7700000000e+05 > > nfo:sampleRate 4.4100000000e+04 > > nfo:fileSize 204670850 > > nfo:fileName The Facedancers - The Facedancers.ape > > nfo:channels 2 > > nfo:duration 2416 > > nmm:trackNumber 1 > > nmm:performer nepomuk:/res/c53dd2ca-4bc0-43a6-b70d-388130dd8bee > > nmm:genre Psychedelic Rock > > nmm:musicAlbum nepomuk:/res/4fba5c68-618e-4d02-a1ce-b52a055e86e0 > > nmm:releaseDate 1972-01-01T00:00:00Z > > kext:indexingLevel 2 > > > <nepomuk:/res/4fba5c68-618e-4d02-a1ce-b52a055e86e0> > rdf:type nmm:MusicAlbum > nao:created 2013-06-01T15:19:24.812Z > nao:lastModified 2013-06-02T09:34:25.415Z > nie:title The Facedancers > > <nepomuk:/res/c53dd2ca-4bc0-43a6-b70d-388130dd8bee> > rdf:type nco:Contact > nao:created 2013-06-01T15:19:24.812Z > nao:lastModified 2013-06-02T09:34:25.415Z > nco:fullname The Facedancers > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
