----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110762/#review33811 -----------------------------------------------------------
This review has been submitted with commit 58d91983b250898eed2d4c1119ad15ad2b8f88f5 by Vishesh Handa on behalf of Michael Olbrich to branch master. - Commit Hook On June 1, 2013, 8:44 a.m., Michael Olbrich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110762/ > ----------------------------------------------------------- > > (Updated June 1, 2013, 8:44 a.m.) > > > Review request for Nepomuk. > > > Description > ------- > > If creating a backend fails then 'backend' is NULL. An error is printed but > initialization continues. With this patch 'virtuosoModel' is set to NULL if > 'backend' is NULL instead of trying to dereference the NULL pointer. A NULL > 'virtuosoModel' is valid: model() creates a dummy model in this case. > > > Diffs > ----- > > libnepomukcore/resource/nepomukmainmodel.cpp a7c4dfd > > Diff: http://git.reviewboard.kde.org/r/110762/diff/ > > > Testing > ------- > > nepomukshell and others don't crash any more. I just get lots of "Could not > find virtuoso backend" errors. > > > Thanks, > > Michael Olbrich > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
