On 01/12/11 03:36 PM, Alan Bateman wrote:
Damjan Jovanovic wrote:
Can I also suggest that Proxy.Type.SOCKS gets deprecated and
Proxy.Type.SOCKS4 and Proxy.Type.SOCKS5 get introduced instead?
Just about every application treats SOCKS 4 and 5 as different proxy
types, only Java tries to lump them together.
I wonder if SOCKS4 is still widely used as SOCKS5 has been around since
1996. Just wondering as it might not be worth doing much on it now.
I agree. I originally considered an API change like Damjan is
suggesting, but backed away from. I considered it to be more destructive
than constructive, deprecating Proxy.Type.SOCKS would force developers
to revisit their code for jdk7, and adding SOCKS4 could be confusing
since we would have then to clarify what SOCKS is.
I believe my proposed solution is a good compromise. It gives access to
V4 proxies where we did not have it before. Yes, it is limited, since
you have to set the property, but we don't expect it to be widely used.
-Chris.
-Alan
