On 03/05/2012 08:46, Chris Hegarty wrote:

On the test, it would be good to run with it with -Djava.net.preferIPv4Stack=true too, but ::0 should not be reachable. I guess the test should check if preferIPv4Stack=true and skip testing with ::0. Or only add ::0 to addresses if !preferIPv4Stack?
Even if preferIPv4Stack is false then IPv6 may be disabled on the system so I suspect it will need to use NetworkInterface to see if there are IPv6 addresses on any of the interfaces. I think we have other tests that need to do the same thing (as you can probably guess, my motive for bringing this up during the review is to ensure that the test would be reliable in such environments).

-Alan

Reply via email to