On 14/01/2014 08:28, Chris Hegarty wrote:
On 13 Jan 2014, at 19:29, Chris Hegarty<chris.hega...@oracle.com> wrote:
On 13 Jan 2014, at 19:23, Dimitar Mavrodiev<dmavrod...@gmail.com> wrote:
Hi Chris,
I can't open the link, but yet I wouldn't mind if you folded your patch into
mine.
How embarrassing. Our public facing server is temporarily offline so I copied
the webrev to a temporary server just to verify it, then obviously forgot it
was an internal link. Sorry about this. I’ll repost a mail when the public
server is back online.
http://cr.openjdk.java.net/~chegar/7100957/webrev.00/webrev/
The Buffered*, flush and try-with-resource changes look good. So will
there be a combined webrev with everything? Also about about Dimi's
change to readSocksReply to handle fragmentation, should that be
included too?
-Alan.