On 12/05/2014 11:55, Paul Sandoz wrote:
On May 12, 2014, at 12:42 PM, Alan Bateman <alan.bate...@oracle.com> wrote:

On 12/05/2014 11:03, Paul Sandoz wrote:
It covers many areas and i have grouped the patches into such areas to aid 
reviewing. When commenting please including core-libs.
The groupings are a bit odd
Yeah, definitely idiosyncratic, i tried to lump 'em in terms of areas where 
people could focus their expertise without creating too few or too many webrevs.

I looked through the -tools and don't see anything escaping so looks good to me. Minor alignment issues in ExpressionParser and TokenMgrError.

I also didn't see any takers for -media so I looked through those changes too. A lot of toString methods and I don't see anything obviously leaking to other threads. The s/retBuffer/sb/ in TreeModelEvent.toString is another multi-line statement, no big deal of course. Minor alignment issue in DefaultTreeSelectionModel and StandardTextSource.

-Alan.


Reply via email to