Reviewed. As a temporary measure to get more diagnostic information on a very difficult intermittent failure, 8065078, I agree with this change. Once we get the additional diagnostic information, then we can revisit this code.
-Chris. On 8 Jan 2015, at 14:16, Mark Sheppard <mark.shepp...@oracle.com> wrote: > Hi > please oblige and review the following additional code to > src/java.base/windows/native/libnet/NetworkInterface_winXP.c > > webrev: http://cr.openjdk.java.net/~msheppar/8068597/webrev/ > > JBS item: https://bugs.openjdk.java.net/browse/JDK-8068597 > > which is a temporary addition to assist in the investigation and diagnosis > of a problem on Windows in the NetworkInterface.getNetworInterfaces() call > flow, > as highlighted in https://bugs.openjdk.java.net/browse/JDK-8065078 > > There are intermittent failures of the GetAdaptersAddresses Windows API > function call. > The extra diagnostic adds the error code to the Exception message thrown. > > regards > Mark