On 10/02/2015 16:20, Chris Hegarty wrote:
On 10 Feb 2015, at 11:35, Alan Bateman <alan.bate...@oracle.com> wrote:
On 09/02/2015 14:57, Chris Hegarty wrote:
:
Updated webrev [ spec and implementation] :
http://cr.openjdk.java.net/~chegar/8064924/04/
The updated javadoc looks good. I haven't had a chance yet to look at the
implementation but I think you will need to update
<top>/make/common/CORE_PKGS.gmk for the spi package.
Sorry, I have the change locally but forgot it. I updated the webrev with the
changes to the top level repo ( below ):
I think the approach is good.
One thing in the implementation is detection for recursive
initialization. In other areas of the platforms
(ClassLoader.getSystemClassLoader and FileSystem.getDefault) then an
exception is thrown. I wonder if we need this here too. If the
initialization of a URLStreamHandlerFactory is dependent on the
deployment of another then it could be very tricky to diagnose as there
isn't (yet) any control on the ordering.
I'd probably use isOverridable or canOverride for the method name.
In the spi package-info.java then I assume it time that the second
paragraph will need to change as there will be other provider interfaces.
-Alan.
