Hi Michael,

On 2016-03-08 12:27, Michael McMahon wrote:
Could I get the following webrev reviewed please?

http://cr.openjdk.java.net/~michaelm/8151299/webrev.1/

get on LinkedList is O(n), so the for-loop in resetInterestOps sneakily has quadratic complexity. One of many reasons ArrayList is almost always the better option.

Iterator-based removal would work, or building a new list to replace pending with might be more efficient. The synchronization scheme seems a bit flaky as well?

Unrelated, but what is debugList? Seems like some leftover dead code.

Thanks!

/Claes

Reply via email to