On 27 Apr 2016, at 17:27, Mandy Chung <mandy.ch...@oracle.com> wrote:
> >> On Apr 27, 2016, at 2:04 AM, Chris Hegarty <chris.hega...@oracle.com> wrote: >> >> This works out quite nice. Webrev updated in-place: >> http://cr.openjdk.java.net/~chegar/8044773/jdk/ > > One comment on the qualified exports of sun.security.action.GetPropertyAction > to jdk.net module. This is a simple utility method used only in a couple > places in jdk.net. I would suggest to change to usage to call > System::getProperty with doPrivileged and no need to add the qualified export > from java.base. Agreed. Removed. Webrev updated in-place: http://cr.openjdk.java.net/~chegar/8044773/jdk/ > As a side note, Sean and I and a couple others are discussing that the > security team may want to have recommended best practices around doPrivileged > and utility methods like this. That would be good. -Chris.
