On Tuesday 24 April 2018 10:12 PM, Ivan Gerasimov wrote:
Hi Vyom!
On 4/23/18 11:29 PM, vyom tewari wrote:
Hi Ivan,
code looks good to me, thanks for doing this cleanup. One minor
comment, in PortConfig.java you can make defaultUpper& defaultLower
as final.
Yes, of course, they should be final! I'll add it before pushing.
I see that Microsoft changed dynamic port range recently do we need
to put some comment in PortConfig.java ?
Can you give a link to a document about what the new range is?
In msdn I could only see that the default range in Vista and later is
[49152, 65535], just as it is hardcoded in JDK.
I think i saw the following
link(https://support.microsoft.com/en-in/help/929851/the-default-dynamic-port-range-for-tcp-ip-has-changed-in-windows-vista)
which tells it changed from (1025,5000) --> (49152,65535) .
Do we support older windows (prior vista)?, if not then it is fine to
use (49152,65535) .
Thanks,
Vyom
With kind regards,
Ivan
Thanks, Vyom
On Tuesday 24 April 2018 09:47 AM, Ivan Gerasimov wrote:
Hello again!
A few other files contain obsolete code, so they can be combined
together in one fix.
The webrev was updated in place:
http://cr.openjdk.java.net/~igerasim/8202154/00/webrev/
Here's the summary of additional changes:
- sun.net.PortConfig.getLower()/getUpper() always return the same
range, so it can be defined with constants,
- NET_GetDefaultTOS() always returns zero, so it can be removed.
Would you please help review this?
With kind regards,
Ivan
On 4/23/18 2:29 PM, Ivan Gerasimov wrote:
Hello!
Some code in TwoStacksPlainDatagramSocketImpl.c is only relevant
for earlier versions of Windows, which are no longer supported as
of JDK 11.
This code can be safely removed.
Also removing an unused argument at
DualStackPlainDatagramSocketImpl.socketCreate().
Would you please help review this cleanup?
BUGURL: https://bugs.openjdk.java.net/browse/JDK-8202154
WEBREV: http://cr.openjdk.java.net/~igerasim/8202154/00/webrev/
Thanks in advance!
--
With kind regards,
Ivan Gerasimov
