Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

Thu, 16 May 2019 03:00:02 -0700

Hi Ao Qi,

It looks good to me.
Thank you for taking care about it!

One minor comment on the fragment:
 474         if (mask != NULL) {
 475             if (parseAllowedMask(mask, isIPv4, &(_peers[_peers_cnt].netmask)) != JDWPTRANSPORT_ERROR_NONE) {
 476                 _peers_cnt = 0;
 477                 fprintf(stderr, "Error in allow option: '%s'\n", mask);
 478                 RETURN_ERROR(JDWPTRANSPORT_ERROR_ILLEGAL_ARGUMENT,
 479                              "invalid netmask in allow option");
 480             }
 481             // for safety update subnet to satisfy the mask
 482             size_t i;
 483             for (i = 0; i < sizeof(_peers[_peers_cnt].subnet); i++) {
 484                 _peers[_peers_cnt].subnet.s6_addr[i] &= _peers[_peers_cnt].netmask.s6_addr[i];
 485             }
 For better compatibility I'd suggest to move the declaration of size_t i
 from line 482 to the begin of block after the line 474.

Thanks,
Serguei


On 5/16/19 02:41, Daniel Fuchs wrote:
Hi Ao Qi,

I'm adding serviceability-dev, since this is for jdwp.

The proposed changes look good to me - but please get
someone from the serviceability team to review this.

best regards,

-- daniel


On 16/05/2019 08:41, Ao Qi wrote:
Hi,

I found build is failed on CentOS 7.6, because of loop initial
declarations. Could I please get reviews for this?

Bug:
https://bugs.openjdk.java.net/browse/JDK-8224028

Webrev:
http://cr.openjdk.java.net/~aoqi/8224028/webrev.00/

Tested:
linux-x86_64-server-release tier1

Thanks,
Ao Qi

Reply via email to