Daniel,
On 16/05/2019 13:23, Daniel Fuchs wrote:
Hi,
Please find below a fix for [1]:
8223856: Replace wildcard address with loopback or local host in
tests - part 8
http://cr.openjdk.java.net/~dfuchs/webrev_8223856/webrev.00/index.html
Looks good.
Some of the test failures weren't all attributable to the use
of the wildcard: in some cases tests make assumptions that
are not guaranteed to be true - e.g. given two different
interfaces `i1` and `i2` you may not assume that because you
can bind to i1 with port `p`, ephemerally allocated, you should
also be able to bind to `i2` with the same port `p`.
In such a case I have taken the liberty to add a retry mechanism,
(that is: try again the whole thing) in the hope
of decreasing the probability that someone else might
be again bound to the new ephemeral port on the other interface.
It's unfortunate that we have to do such things, but I agree
with the pragmatic approach. It should improve the reliability
of these few tests.
-Chris.
