On 04/06/2019 13:56, Chris Hegarty wrote:
Alan,
On 4 Jun 2019, at 13:50, Alan Bateman <alan.bate...@oracle.com> wrote:
On 04/06/2019 13:48, Chris Hegarty wrote:
Updated as suggested:
https://cr.openjdk.java.net/~chegar/8225214/webrev.01/
I assume soLinger doesn't need to be public. I guess I'd rename it something
like testSoLingerValues so that it's a bit cleaner when reading the call in
doSocketTests but what you have is fine too.
Both your comments are correct / better. I updated the webrev in place.
Looks good.
