On 06/06/2019 16:25, Chris Hegarty wrote:
The changes in 8220493 (Prepare Socket/ServerSocket for alternative
platform SocketImpl) disallow a number of scenarios where it is not
possible for `ServerSocket::implAccept` to accept a new connection with
a given Socket.
Right, the original CSR has all the gory details. We decided at the time
to leave any implementation notes/clarification to later issues. Part of
the context for that decision was the number of SocketImpl issues coming
to light when trying to replace the old SocketImpl.
This change proposes to 1) update the specification to
clarify the expected behavior of `implAccept` for these scenarios, i.e.
throw an IOException, and 2) add an implNote describing the behavior of
the system-default SocketImpl.
Additionally, prior to the `implAccept` invocation the given Socket
may be connected, closed, or even have socket options set. A note is
added to warning against this, as the behavior cannot be guaranteed.
The proposed javadoc changes look good.
-Alan.
