On 10/07/2019 18:45, Michael McMahon wrote:
Hi Daniel,
I think I prefer the pattern of URL creation where you use URIBuilder
and then toURL() as the final step, rather than toString() and then new
URL(string).
But, it's not a big deal.
Done.
NoLoopbackPackets looks like it could be simplified with try with
resources (line 166)
unless you expect the close() to sometimes throw an exception that needs
to be ignored .?
Good point.
Can you use the single-arg version of Collectors.joining() in B6210227.java
as the prefix and suffix are empty?
Done.
What about using InetAddress.isAnyLocalAddress() instead of testing for
zero bytes
in isWildcard()?
The original test did a 0 comparison and I wanted to keep that.
New webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8227539/webrev.01/
I'm retesting, and if there is no further comments I'll push if
the test results are successful.
best regards,
-- daniel
Looks fine otherwise.
Thanks,
Michael.
