Hi Julia,
Minor comments:
test/jdk/java/net/httpclient/LineStreamsAndSurrogatesTest.java#2:
Could you please add the missing comma after the last modification year,
i.e. "2018, 2019,"
test/jdk/java/net/httpclient/LineSubscribersAndSurrogatesTest.java#2:
Same stuff: "2018, 2019,"
Otherwise looks good to me
With Best Regards,
Aleksei
On 23/08/2019 17:16, Julia Boes wrote:
Hi,
Please find below a fix of three httpclient tests for which testng
trivially passed without running any tests.
In LineSubscribersAndSurrogatesTest and LineStreamsAndSurrogatesTest,
the access modifier of the methods in question was changed to public.
For AbstractThrowingPushPromises, the header was adjusted so that it
no longer appears as a test. This class sets up an abstract framework
and the real tests are all implemented in subclasses.
Bug: https://bugs.openjdk.java.net/browse/JDK-8230000
Webrev: http://cr.openjdk.java.net/~dfuchs/jboes/8230000/webrev.01/
Regards,
Julia
