Hello Daniel, On 28/08/19 8:45 PM, Daniel Fuchs wrote: > Hi Jaikiran, > > On 28/08/2019 15:47, Jaikiran Pai wrote: >> Can I please get a review and a sponsor for the patch for >> https://bugs.openjdk.java.net/browse/JDK-8230310? The patch is hosted as >> a webrev at [1]. >> >> As noted in that JBS issue, this is a follow-up patch to the changes >> that were done as part of [2]. During that patch review, it was decided >> that remaining usages of ProxySelector.select() would be updated >> accordingly if relevant. My search for this method usage shows this >> java.net.SocksSocketImpl as one such relevant place. > > AFAICS your webrev looks fine, but could you try to write a test > for that?
I checked for existing tests to see if I could add something to them but couldn't find any, so (lazily) decided not to attempt a new one :) But I agree - this one will benefit from a test. I'll add one and send an updated webrev soon. -Jaikiran
