Hi Daniel,
I've added the comment, and you can find it in the new webrev below.
webrev: http://cr.openjdk.java.net/~pconcannon/8234103/webrevs/webrev.01/
Kind regards,
Patrick
On 14/11/2019 12:12, Daniel Fuchs wrote:
Hi Patrick,
Thanks for helping getting rid of this old technical debt!
In DualStackPlainDatagramSocketImpl.java:
64 DualStackPlainDatagramSocketImpl(boolean exclBind) {
65 super(false);
Maybe add a comment to clarify the meaning of `false`:
65 super(false); // DualStackPlainDatagramSocketImpl doesn't
support multicast
Otherwise looks good!
best regards,
-- daniel
On 14/11/2019 11:58, Patrick Concannon wrote:
Hi,
Could someone please review my fix for issue JDK-8234103
'DatagramSocketImpl::socket is not needed' ?
DatagramSocketImpl has a socket field that links back to the
DatagramSocket, which is only used to determine whether this
DatagramSocket support Multicast or not. This fix removes the
DatagramSocket object and replaces it with a boolean 'isMulticast'
field in AbstractPlainDatagramSocketImpl.
bug: https://bugs.openjdk.java.net/browse/JDK-8234103
webrev:
http://cr.openjdk.java.net/~pconcannon/8234103/webrevs/webrev.00/
Kind regards,
Patrick
