Doh! My mistake. I dropped this part in the test:
http://cr.openjdk.java.net/~dfuchs/webrev_8235141/webrev.02
cheers,
-- daniel
On 04/12/2019 16:42, Chris Hegarty wrote:
Daniel,
On 04/12/2019 14:24, Daniel Fuchs wrote:
This test doesn't test NetworkChannel.
This is what I was referring to:
{ Configurable.of(SocketChannel.open()), SOCKET_OPTIONS }
..
static Configurable<NetworkChannel, IOException> of(NetworkChannel
socket) {
return new ConfigurableImpl<>(socket, socket::setOption,
socket::getOption, socket::supportedOptions,
socket::close);
}
If this is somehow not testing NetworkChannel::supportedOptions, et,
then forget my comment. If it is, then it is a candidate to drop, if
needed.
But it does check that the adapters behave consistently with the spec
of their java.net super class.
Good.
-Chris.
