Re: [PATCH] 7006496: Use modern Windows API to retrieve OS DNS servers

[Chris Hegarty]

> On 24 Dec 2019, at 10:12, Aleks Efimov <aleksej.efi...@oracle.com> wrote:
> 
> Hi Anuraag,
> 
> We need additional approval from openjdk reviewer. After that I will sponsor 
> your change.
> 
> Merry Christmas and a Happy New Year,
> Aleksei
> 
> On 18/12/2019 06:08, Anuraag Agrawal wrote:
>> ...
>> http://cr.openjdk.java.net/~aefimov/anuraaga/7006496/03/
>> 

I think that this mainly looks good. A few small comments:

1) If getAdapters returns an error ( ret != ERROR_SUCCESS ), then there will be 
a JNI pending exception, right? so loadDNSConfig0 should not unconditionally 
throw OOME.

2)  the output of the append should be “abc,def”, right?
  53  *  strappend(s1="abc", "def")  => "abc def”

3) I wonder if we should bump MAX_STR_LEN, while here?

-Chris.