I think the WebSocket part of the changeset look good to me. I have gone through the non-WebSocket part of the changes shallowly. I'm not an expert.
> On 14 Jan 2020, at 17:59, Daniel Fuchs <daniel.fu...@oracle.com> wrote: > > Hi Pavel, > > On 14/01/2020 17:54, Pavel Rappo wrote: >> That changeset applies fine, thanks. >> I was wondering what you had in mind when added OpeningHandshake:225. >> Was it for general robustness or you ran into something in particular? > > More for general robustness. Sometimes assertion errors are fired when > running tests. These are not exceptions. And sometimes a test gets > stuck because it's using a proxy that's doing one connection at a > time and waits fro the previous connection to be closed before > accepting the next. > > But I didn't have to do this change to make something pass. > > best regards, > > -- daniel >
