On 14/01/2020 17:49, Daniel Fuchs wrote:
Hi Alan,
Globally this looks good to me. One small nit is that the `oldImpl`
field could now also become final (by applying the same trick you
did with createImpl - that is - have oldImpl() return a boolean
rather than set the field and assign the result in the constructor.
Thanks for going through this. I tried to keep the changes to
DatagramSocket to a minimum but I don't mind making an exception for
oldImpl. It's a slippery slope as there is a lot of technical debt in
this area. Also oldImpl is the the support for DatagramSocketImpl that
were compiled for JDK 1.3 or older and I really hope we can drop that
code soon.
Here's the updated webrev that changes oldImpl to be final.
http://cr.openjdk.java.net/~alanb/8236925/2/webrev/
-Alan
