On 26/03/2020 20:35, Daniel Fuchs wrote:
Hi Alan.
On 26/03/2020 17:29, Alan Bateman wrote:
NetworkConfiguration.isTestable - is the hardcoded check for "awdl"
needed? I don't think I've seen it with non-link local address so I
can't tell if it is needed. I'm
It might no longer be needed, but we know that awdl is always
the wrong choice, so excluding it right away won't harm.
That was part of Chris's fix for 7155591 [1].
Okay, it was just a question on whether it was needed. I looked at 3
systems with an awdl interface and all had just an IPv6 link local
address. I was also wondering about the Teredo tunnel but I couldn't
find a system quickly to see what the default configuration. I think the
main point is that your change will filter out most of the annoying
tunnels and adaptors that have complicated testing in recent years.
I've applied your other comments:
http://cr.openjdk.java.net/~dfuchs/webrev_8241336/webrev.02/
This mostly looks good except that I'd prefer if the the code in
assertNotSame be moved into testSendNoReceive (it was an oversight in
the original test that testSendNoReceive didn't have this check).
-Alan
