Hi,
Thanks for the feedback.
Lance - I swapped out expectThrows for assertThrows, as requested.
Chris - I put in an extra check in the tests to ensure that the new code
doesn’t interfere with the Security Manager checks already present in
the source.
The new webrev can be found here:
http://cr.openjdk.java.net/~pconcannon/8240533/webrevs/webrev.01/
<http://cr.openjdk.java.net/~pconcannon/8240533/webrevs/webrev.01/>
Kind regards,
Patrick
On 31/03/2020 15:33, Chris Hegarty wrote:
Patrick,
On 31 Mar 2020, at 15:08, Daniel Fuchs <daniel.fu...@oracle.com> wrote:
..
bug: https://bugs.openjdk.java.net/browse/JDK-8240533
webrev: http://cr.openjdk.java.net/~pconcannon/8240533/webrevs/webrev.00/
Look good Patrick.
The check is deliberately performed after the security manager checks, right?
If so, it is worth asserting this in a test.
-Chris.
