Hi, Alan: That’s great. Thanks for the feedback!
Daniel: Well spotted. I’ve mades those changes now and you can find them in the updated webrev below. http://cr.openjdk.java.net/~pconcannon/8244582/webrevs/webrev.01/ <http://cr.openjdk.java.net/~pconcannon/8244582/webrevs/webrev.01/> Kind regards, Patrick > On 28 May 2020, at 04:18, Vyom Tiwari <vyomm...@gmail.com> wrote: > > Hi Patrick, > > Changes looks good to me. > > Thanks, > Vyom > > On Wed, May 27, 2020 at 9:12 PM Patrick Concannon > <patrick.concan...@oracle.com <mailto:patrick.concan...@oracle.com>> wrote: > Hi, > > Could someone please review my webrev and CSR for JDK-8244582 'Remove > terminally deprecated Solaris-specific SO_FLOW_SLA socket option'? > > This patch removes `ExtendedSocketOptions. SO_FLOW_SLA`, `SocketFlow` > and `SocketFlow.Status` which were terminally deprecated in JDK 14 in > preparation for the removal of the Solaris port. JEP 381 will remove > this port in JDK 15 so the socket option and its supporting classes can > now be removed. > > > bug: https://bugs.openjdk.java.net/browse/JDK-8244582 > <https://bugs.openjdk.java.net/browse/JDK-8244582> > csr: https://bugs.openjdk.java.net/browse/JDK-8245984 > <https://bugs.openjdk.java.net/browse/JDK-8245984> > webrev: http://cr.openjdk.java.net/~pconcannon/8245828/webrevs/webrev.00/ > <http://cr.openjdk.java.net/~pconcannon/8245828/webrevs/webrev.00/> > > > Kind regards, > > Patrick > > > > -- > Thanks, > Vyom
