Hi, After discussion with Chris & Alan I have slightly reworded the API documentation, and ensured the MultiExchange is only weakly referenced from the MinimalFuture to avoid the risk of pinning the exchange in memory after it is no longer needed.
Also I added a trivial test for the case where the thread is interrupted just before calling HttpClient::send. The new webrev is at: http://cr.openjdk.java.net/~dfuchs/webrev_8245462/webrev.03/ The generated API documentation for the HttpClient class can be seen at: http://cr.openjdk.java.net/~dfuchs/webrev_8245462/docs.03/java.net.http/java/net/http/HttpClient.html The CSR has been updated with the latest changes: https://bugs.openjdk.java.net/browse/JDK-8251312 best regards, -- daniel On 07/08/2020 19:19, Daniel Fuchs wrote:
Hi, Here is the new webrev that goes on top of the changes from 8229822 (which are already pushed). http://cr.openjdk.java.net/~dfuchs/webrev_8245462/webrev.02/ I have also written the CSR: https://bugs.openjdk.java.net/browse/JDK-8251312 feedback - and reviewers - welcome :-) best regards, -- daniel
