On Tue, 15 Sep 2020 09:31:16 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> Replaced the use of ThreadLocalCoders with regular non-caching >> CharsetEncoder and added a benchmark to confirm that >> there is no performance impact. > > test/micro/org/openjdk/bench/java/net/ThreadLocalParseUtil.java line 65: > >> 63: >> 64: @Benchmark >> 65: @CompilerControl(CompilerControl.Mode.DONT_INLINE) > > Why `DONT_INLINE`, though? It is useful for looking at disassembly, but it > penalizes the benchmark for the regular > performance runs. I used the ThreadLocalURI benchmark as a starting point, which includes this annotation. You are right, it's probably not of use here. ------------- PR: https://git.openjdk.java.net/jdk/pull/170
