On Fri, 6 Nov 2020 12:49:48 GMT, Daniel Fuchs <[email protected]> wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8253005: Restructured test to use @BeforeTest/@AfterTest
>
> test/jdk/java/net/httpclient/SendResponseHeadersTest.java line 93:
>
>> 91: @AfterTest
>> 92: public void tearDown() {
>> 93: server.stop(2);
>
> we usually call `server.stop(0)` in tests.
Parameter changed in commit
https://github.com/openjdk/jdk/pull/1014/commits/927b2ca213473825b7492c77db23055c55a9768d
> test/jdk/java/net/httpclient/SendResponseHeadersTest.java line 81:
>
>> 79: @Test
>> 80: public void testSend() throws Exception {
>> 81: HttpClient client = HttpClient.newHttpClient();
>
> It would be better to set up a NO_PROXY proxy selector.
Added NO_PROXY proxy selector in commit
https://github.com/openjdk/jdk/pull/1014/commits/927b2ca213473825b7492c77db23055c55a9768d
> test/jdk/java/net/httpclient/SendResponseHeadersTest.java line 76:
>
>> 74: loopback.getHostName(),
>> 75: server.getAddress().getPort(),
>> 76: path, null, null);
>
> Can we use the URIBuilder here?
Replaced with URIBuilder as requested. See
https://github.com/openjdk/jdk/pull/1014/commits/927b2ca213473825b7492c77db23055c55a9768d
-------------
PR: https://git.openjdk.java.net/jdk/pull/1014
