On Mon, 18 Jan 2021 08:25:34 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Jamie Le Tual has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed formatting > > src/java.base/unix/native/libnet/Inet6AddressImpl.c line 713: > >> 711: This usually requires "root" privileges, so it's likely to fail. >> 712: If all else fails, fall back to TCP and implement tcp echo >> 713: */ > > This is one of the block comments that needs a tidy, same thing in > Inet4Address.c. Also check the // comments and you'll see some of the > inconsistencies there. It's just nit picking, the patch itself is good, just > hard to test. OK, is it the fact that it's a block comment instead of a line comment? Is the indentation not right? I don't see what needs to be cleaned up ------------- PR: https://git.openjdk.java.net/jdk/pull/1502
