On Thu, 4 Mar 2021 00:27:52 GMT, Xue-Lei Andrew Fan <[email protected]> wrote:
>> Vyom Tewari has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - resolve jcheck issue.
>> - put if block which will prevent host being set twice in case of
>> SSLSocketImpl
>
> src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.java line
> 569:
>
>> 567: SSLParameters paramaters = s.getSSLParameters();
>> 568:
>> paramaters.setEndpointIdentificationAlgorithm("HTTPS");
>> 569: if (!(s instanceof SSLSocketImpl)) {
>
> Please have a comment that the host has been set previously for SSLSocketImpl.
done
-------------
PR: https://git.openjdk.java.net/jdk/pull/2583