On Mon, 12 Apr 2021 15:21:05 GMT, Conor Cleary <ccle...@openjdk.org> wrote:

> ### Description
> `Inet6Address/B6206527.java` test creates two instances of ServerSocket, both 
> of which are explicity bound to a Link-Local address. Neither of the 
> ServerSocket instances are explicitly closed meaning there is no guarantee 
> that their associated resources are freed. 
> 
> ### Fix
> Each ServerSocket is instantiated in a try-with-resources block. This ensures 
> that in both cases of success or failure within the try-with-resources block, 
> the sockets are always closed thanks to ServerSocket implementing Closeable. 
> The test is also now started in othervm mode as an added assurance of the 
> test's isolation in the event that resources are not freed.

Hi Conor,
The change looks good to me.

-------------

Marked as reviewed by aefimov (Committer).

PR: https://git.openjdk.java.net/jdk/pull/3437

Reply via email to