On Thu, 27 May 2021 13:20:26 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Hi, >> >> Please find below a fix for: >> 8265367: [macos-aarch64] 3 java/net/httpclient/websocket tests fail with >> "IOException: No buffer space available" >> >> The Pending* websocket tests create a server that accepts sockets to create >> a websocket, but never read data from the websocket in order to get the >> client side to block once the buffers are full. >> Unfortunately, the PendingOperations:cleanup methods was not called after >> each test methods invocations, causing sockets to leak and relying on the gc >> to cleanup. >> >> This caused an "IOException: No buffer space available" to be raised >> intermittently but reliably (1 run out of 50 in PendingTextPingClose). >> >> The fix makes sure that cleanup() is called appropriately after each test >> method invocation. >> It also tweaks PendingTextPingClose - which seemed to be failing more >> frequently - to use smaller send and receive buffers in order to reach the >> point at which the client bocks more quickly and avoid wasting system >> resources. > > Daniel Fuchs has updated the pull request incrementally with two additional > commits since the last revision: > > - Added missing spaces after catch > - Added missing brace in comment Marked as reviewed by chegar (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/4222
