On Wed, 2 Jun 2021 17:22:01 GMT, Mahendra Chhipa
<github.com+34924738+mahendrachh...@openjdk.org> wrote:
> …ency on sun.net.www.MessageHeader and
test/jdk/java/net/Authenticator/B4722333.java line 79:
> 77: req.getResponseHeaders().set("Connection",
> "close");
> 78: req.getResponseHeaders().add("WWW-Authenticate",
> "Basic realm=\"foobar\"");
> 79: req.getResponseHeaders().add("WWW-Authenticate",
> "Foo realm=\"bar\"");
I believe this will change what the test is testing. I suggest replacing these
two lines with:
req.getResponseHeaders().add("WWW-Authenticate", "Basic realm="foobar" Foo
realm="bar"");
as in the original version of the test.
test/jdk/java/net/Authenticator/B4722333.java line 84:
> 82: case 4:
> 83: req.getResponseHeaders().set("Connection",
> "close");
> 84: req.getResponseHeaders().set("WWW-Authenticate",
> "Digest realm=\"biz\" domain=/foo nonce=\"thisisnonce \"");
I'm not very comfortable with changing the logic of the test. Can we keep the
strings identical please?
test/jdk/java/net/Authenticator/B4722333.java line 91:
> 89: req.getResponseHeaders().set("Connection",
> "close");
> 90: req.getResponseHeaders().set("WWW-Authenticate",
> "Digest realm=\"bizbar\" domain=/biz nonce=\"hereisanonce\"");
> 91: req.getResponseHeaders().add("WWW-Authenticate",
> "Basic realm=\"foobar\" Foo realm=\"bar\"");
Same remark here. Changing one WWW-Authenticate line into two WWW-Authenticate
lines may not trigger the same code path in the client.
test/jdk/java/net/Authenticator/B4722333.java line 98:
> 96: req.getResponseHeaders().set("WWW-Authenticate",
> "Foo p1=1 p2=2 p3=3 p4=4 p5=5 p6=6 p7=7 p8=8 p9=10");
> 97: req.getResponseHeaders().add("WWW-Authenticate",
> "Digest realm=foobiz domain=/foobiz nonce=newnonce");
> 98: req.getResponseHeaders().add("WWW-Authenticate",
> "Basic realm=bizbar");
Here again. Please keep the strings identical.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4317
