On Fri, 2 Jul 2021 16:14:25 GMT, Brian Burkhalter <[email protected]> wrote:
>> Please review this change to the Unix implementations of
>> `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state ==
>> ChannelState.UNINITIALIZED`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8269481: In test use othervm mode and an automatically allocated port
test/jdk/com/sun/nio/sctp/SctpMultiChannel/CloseDescriptors.java line 92:
> 90: if (nfds > 3) {
> 91: String msg =
> 92: String.format("Number of open descriptors (%d) > 2%n",
> nfds);
Hello Brian,
The if condition checks for `> 3` whereas the error message states `> 2`.
Should the error message be changed? Also, I see that there's a `MAX_DESC`
constant in this test, but from what I can see isn't used anywhere? Perhaps
that's the constant you wanted to use in this if block and the error message?
-------------
PR: https://git.openjdk.java.net/jdk/pull/4621
