On Wed, 19 Jan 2022 22:25:43 GMT, Weijun Wang <[email protected]> wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changes after first review round
>
> src/java.naming/share/classes/com/sun/jndi/ldap/sasl/LdapSasl.java line 133:
>
>> 131:
>> (String)env.get(TlsChannelBinding.CHANNEL_BINDING_TYPE));
>> 132: } catch (ChannelBindingException e) {
>> 133: throw new SaslException(e.getMessage());
>
> How about setting `e` as cause of new exception? In `TlsChannelBinding.java`
> the when the original exception was thrown (the 2nd throws) there was a cause.
Agreed.
> src/java.security.jgss/share/classes/module-info.java line 36:
>
>> 34: module java.security.jgss {
>> 35: requires java.naming;
>> 36: requires java.security.sasl;
>
> Can this be removed now?
Yes, well spotted!
-------------
PR: https://git.openjdk.java.net/jdk/pull/7065
