On Thu, 20 Jan 2022 11:16:16 GMT, Daniel Fuchs <[email protected]> wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed sasl module dependency and added SaslException cause
>
> src/java.base/share/classes/sun/security/util/ChannelBindingException.java
> line 31:
>
>> 29: * Thrown by TlsChannelBinding if an error occurs
>> 30: */
>> 31: public class ChannelBindingException extends Exception {
>
> Should this extend `GeneralSecurityException` instead? Or should we just
> remove this class and throw plain `GeneralSecurityException` in
> `TlsChannelBinding` ?
I think a distinct exception is necessary. I don't have a strong opinion on
whether it should extend GeneralSecurityException.
> src/java.naming/share/classes/com/sun/jndi/ldap/sasl/LdapSasl.java line 143:
>
>> 141: tlsCB = TlsChannelBinding.create(cert);
>> 142: } catch (ChannelBindingException e) {
>> 143: throw new SaslException(e.getMessage());
>
> Why is there a difference compared to line 133?
Right, that was a mistake.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7065
