On Mon, 24 Jan 2022 13:54:12 GMT, Daniel Fuchs <[email protected]> wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains eight additional
>> commits since the last revision:
>>
>> - fixed failing test issue and update for latest comments
>> - Merge branch 'master' into spnego
>> - added root cause to NamingException
>> - more tidy-up
>> - removed sasl module dependency and added SaslException cause
>> - changes after first review round
>> - cleanup but still no test. Will be added in closed repo
>> - First version of fix. No test and feature enabled always.
>
> src/java.naming/share/classes/com/sun/jndi/ldap/sasl/LdapSasl.java line 260:
>
>> 258: * @throws ChannelBindingException
>> 259: */
>> 260: private static TlsChannelBindingType parseType(String cbType)
>> throws ChannelBindingException {
>
> Maybe this method could throw NamingException directly now? That would avoid
> wrapping CBE into NamingException?
My opinion is this method should be put back.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7065
