On Thu, 19 May 2022 10:46:35 GMT, Pavel Rappo <pra...@openjdk.org> wrote:
> > > What looks questionable is rearrangement of asserts: when `assertHangs` > > > moves down. assertNotDone(cfClose) can transitorry pass even if ping has > > > not hung. > > > > > > `assertHangs` either waits for 5 seconds or throws an exception, so > > `assertNotDone` after `assertHangs` is pretty much equivalent to > > `assertHangs` > > The order of these checks is important. On the other hand, I'm not sure how > important that importance is for the tests. With the proposed change, the > test might become more permissive than it should've been. > > Separately, why does this PR change `assertHangs(cfClose)` to > `assertNotDone(cfClose)`? > > The fact that you say that the tests still pass gives me some confidence. I'm > just trying to make sure that the tests still test what we think they test. Modified the tests to make it clear that we expect both CFs to hang. Let me know if that addresses your concerns. ------------- PR: https://git.openjdk.java.net/jdk/pull/8746
