On Wed, 29 Jun 2022 15:04:46 GMT, Daniel Fuchs <[email protected]> wrote:

>> Andrey Turbanov has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   8289385: Cleanup redundant synchronization in Http2ClientImpl
>>   add comments
>
> src/java.net.http/share/classes/jdk/internal/net/http/Http2ClientImpl.java 
> line 59:
> 
>> 57: 
>> 58:     private final HttpClientImpl client;
>> 59:     private boolean stopping;
> 
> before this line and before line 68 - could you please add a comment that 
> says:
> 
> // only accessed from within synchronized blocks
> 
> 
> Otherwise it looks reasonable to me.

Done

-------------

PR: https://git.openjdk.org/jdk/pull/9311

Reply via email to