On Mon, 21 Nov 2022 06:47:52 GMT, Jaikiran Pai <[email protected]> wrote:
> Can I please get a review for this small change which addresses > https://bugs.openjdk.org/browse/JDK-8297211? > The change checks if the `content-length` header value is present before > parsing it into a `Long` value. The commit also now catches the more specific > `NumberFormatException` instead of a general `Exception`. Given the context > of the code, I believe this change in the exception type in the catch block > should be fine. > > No new test has been introduced given the nature of this change. I have > triggered existing tests to verify no unexpected regressions show up. Your fix looks good, but there are two other places in the file with the same pattern in getHeaderFieldDate() and getHeaderFieldLong(). Can you please fix them as well? ------------- Changes requested by simonis (Reviewer). PR: https://git.openjdk.org/jdk/pull/11258
