On Thu, 1 Dec 2022 15:02:45 GMT, Per Minborg <[email protected]> wrote:
>> This PR proposes a variety of modernisations to the `jdk.sctp` module. >> >> During the fix of https://bugs.openjdk.org/browse/JDK-8296024, several >> improvement areas were identified including: >> >> * Replacing duplicate code segments >> * Making certain fields final >> * Using enhanced switch >> * Using records >> * Fixing typos >> * Marking fields participating in serialisation with `@Serial` >> * Modernizing toString() implementations >> * Using pattern matching >> * Using diamond operators > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Add import src/jdk.sctp/share/classes/com/sun/nio/sctp/SctpStandardSocketOptions.java line 72: > 70: public static final SctpSocketOption<Boolean> SCTP_EXPLICIT_COMPLETE > = new > 71: SctpStdSocketOption<>("SCTP_EXPLICIT_COMPLETE", Boolean.class, > 72: SctpStdSocketOption.SCTP_EXPLICIT_COMPLETE); The indentation here looks to be missing. (And was before). src/jdk.sctp/share/classes/com/sun/nio/sctp/SctpStandardSocketOptions.java line 162: > 160: <SctpStandardSocketOptions.InitMaxStreams> SCTP_INIT_MAXSTREAMS = > 161: new SctpStdSocketOption<>( > 162: "SCTP_INIT_MAXSTREAMS", > SctpStandardSocketOptions.InitMaxStreams.class); Please fix the indentation, here and in the rest of the file/files. ------------- PR: https://git.openjdk.org/jdk/pull/11418
